Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate display.color as var display color #3891

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Aug 20, 2024

Fixes this issue brought up on Slack.

Don't quite know why it works, but it does?

Before / After

Before After

CleanShot 2024-08-21 at 14 01 36

CleanShot 2024-08-21 at 13 59 59

@owidbot
Copy link
Contributor

owidbot commented Aug 20, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-variable-display-color

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-20 15:46:15 UTC
Execution time: 1.16 seconds

@marcelgerber marcelgerber force-pushed the variable-display-color branch from 9dc65a1 to be30b86 Compare August 21, 2024 12:50
@marcelgerber marcelgerber changed the title test: propagate display.color as var display color fix: propagate display.color as var display color Aug 21, 2024
@marcelgerber marcelgerber marked this pull request as ready for review August 21, 2024 13:03
@marcelgerber marcelgerber merged commit 127b286 into master Aug 21, 2024
20 checks passed
@marcelgerber marcelgerber deleted the variable-display-color branch August 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants