🐛 fix redirects from draft gdoc deletion #3844
Conversation
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-08-05 14:03:51 UTC |
| [getCanonicalUrl("", gdoc), "/"] | ||
| ) | ||
| await triggerStaticBuild(res.locals.user, `Deleting ${gdoc.slug}`) | ||
| const gdocSlug = getCanonicalUrl("", gdoc) |
There was a problem hiding this comment.
So, if I see this correctly, if gdoc is a fragment then we'll end up with gdocSlug = "". We should explicitly handle that case, too - don't know what currently happens if we ever insert an empty string into the table.
There was a problem hiding this comment.
Looking at it, it'll probably generate an incorrect redirect rule (something like / 302) which CF will then ignore. Still not great.
There was a problem hiding this comment.
So rigorous! 😍
Went with a falsey check instead of an exception for type == Fragment 👍
ikesau
force-pushed
the
redirect-creation
branch
from
f39934a to
75edba8
Compare
Ensures we don't create redirects or trigger rebuilds for drafts, and that we never create redirects if the gdoc's full slug is
/