Fix updatedAt field initialization in gdocs_posts
#3839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3832 Fix the issue where `gdocs_posts.updatedAt` is often set to the Unix epoch instead of `NULL`. * **db/model/Gdoc/GdocFactory.ts** - Replace `new Date(null)` with `null` in the `updatedAt` field initialization. - Ensure `updatedAt` is explicitly set to `NULL` if no updates have occurred post create. * **db/model/Post.ts** - Replace `new Date(null)` with `null` in the `updatedAt` field initialization. - Ensure `updatedAt` is explicitly set to `NULL` if no updates have occurred post create.
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
|
@marcelgerber yes that looks like it should fix it. I haven't checked if this can come from other places as well but it's definitely good to fix these two |
danyx23
approved these changes
Aug 19, 2024
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
|
@larsyencken I think we can merge this |
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3832
Fix the issue where
gdocs_posts.updatedAtis often set to the Unix epoch instead ofNULL.db/model/Gdoc/GdocFactory.ts
new Date(null)withnullin theupdatedAtfield initialization.updatedAtis explicitly set toNULLif no updates have occurred post create.db/model/Post.ts
new Date(null)withnullin theupdatedAtfield initialization.updatedAtis explicitly set toNULLif no updates have occurred post create.Todo