Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 add OWID_KOS flag #3837

Closed
wants to merge 2 commits into from
Closed

🎉 add OWID_KOS flag #3837

wants to merge 2 commits into from

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Aug 1, 2024

AFAICT this is the only country in regions.ts that doesn't have a flag (which was resulting in a 404 for the data catalog's new entity picker)

I got this from https://upload.wikimedia.org/wikipedia/commons/1/1f/Flag_of_Kosovo.svg and ran it through https://jakearchibald.github.io/svgomg/ at minimal precision (8.13k → 1.72k) to no visual loss in clarity that I could perceive.

@ikesau ikesau requested a review from marcelgerber August 1, 2024 20:07
@ikesau ikesau self-assigned this Aug 1, 2024
@owidbot
Copy link
Contributor

owidbot commented Aug 1, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-kosovo-flag

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-01 20:15:15 UTC
Execution time: 1.25 seconds

@ikesau
Copy link
Member Author

ikesau commented Aug 5, 2024

BTFO by #3848

@ikesau ikesau closed this Aug 5, 2024
@ikesau ikesau deleted the kosovo-flag branch December 6, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants