Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist search query in URL parameters #3831

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

larsyencken
Copy link
Contributor

Fixes #3803

Persist search queries in the admin across browser navigation.

  • Update onSearchInput method to update the URL parameters with the search input state.
  • Update componentDidMount method to initialize the search input state from the URL parameters.

Fixes #3803

Persist search queries in the admin across browser navigation.

* Update `onSearchInput` method to update the URL parameters with the search input state.
* Update `componentDidMount` method to initialize the search input state from the URL parameters.
@owidbot
Copy link
Contributor

owidbot commented Jul 31, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-larsyencken-persist-search-query

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-07-31 14:02:55 UTC
Execution time: 1.20 seconds

@larsyencken larsyencken requested a review from marcelgerber July 31, 2024 15:21
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this works well!

@larsyencken larsyencken merged commit 212c223 into master Aug 7, 2024
27 checks passed
@larsyencken larsyencken deleted the larsyencken/persist-search-query branch August 7, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search queries in the admin should be persisted across browser navigation
3 participants