🔨 Make more db relationships cascade on delete for charts #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if you tried to delete a chart in the DB, it would fail if there were any linked rows in `suggested_chart_revisions` (some charts) or `chart_dimensions` (all charts). With this migration, both of those relationships cascade on delete, meaning that deleting a chart will succeed even if there are associated chart dimension rows and suggested revisions. However, other relationships, such as usage in explorers, will still prevent deletion.
|
This has been QA'd basically by checking that the migrations succeed in local dev, and attempting to delete some charts from local dev, and checking that deletes do cascade for these relationships. |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 2 (dac81a) ❌ Edited: 2024-07-31 15:32:14 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if you tried to delete a chart in the DB, it would fail if there were any linked rows in
suggested_chart_revisions(some charts) orchart_dimensions(all charts).With this migration, both of those relationships cascade on delete, meaning that deleting a chart will succeed even if there are associated chart dimension rows and suggested revisions. However, other relationships, such as usage in explorers, will still prevent deletion.