Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show DI newsletter banner on top of cookie banner #3824

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Don't show DI newsletter banner on top of cookie banner #3824

merged 2 commits into from
Jul 30, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Jul 30, 2024

No description provided.

@rakyi rakyi requested a review from marcelgerber July 30, 2024 12:48
@owidbot
Copy link
Contributor

owidbot commented Jul 30, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fix-overlapping-banners

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-07-30 12:56:15 UTC
Execution time: 1.22 seconds

marcelgerber
marcelgerber approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's go!

site/CookiePreferencesManager.tsx Outdated Show resolved Hide resolved
@rakyi rakyi merged commit 4909eca into master Jul 30, 2024
20 checks passed
@rakyi rakyi deleted the fix-overlapping-banners branch July 30, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelgerber marcelgerber marcelgerber approved these changes

Assignees

@rakyi rakyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rakyi @owidbot @marcelgerber