Optimize latest data insights data #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-07-29 17:57:50 UTC |
ikesau
reviewed
Jul 29, 2024
baker/SiteBaker.tsx
Outdated
Comment on lines
834
to
837
| // We don't need latest data insights nor their images on the | ||
| // index page. | ||
| dataInsight.latestDataInsights = [] | ||
| dataInsight.imageMetadata = attachments.imageMetadata |
There was a problem hiding this comment.
This confused me just a little bit because I was expecting this adjustment to be done right next to the renderDataInsightsIndexPage call.
Would you mind clarifying that? 🙂
There was a problem hiding this comment.
I tweaked it a bit, let me know if it isn't good enough. I kept it in the loop, because that's where we have the attachments.imageMetadata for each data insight.
ikesau
approved these changes
Jul 29, 2024
rakyi
force-pushed
the
optimize-latest-data-insights
branch
from
f417c65 to
d53dcb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could optimize the feed more, but I'm not sure if it's worth it. I haven't touched that part with the new features, i.e. after this fix, the feed page size is back to where it was before the new DI redesign.