-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement MissingDataStrategy
for StackedDiscreteBar
chart
#3821
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-08-15 15:48:21 UTC |
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
Looking at the SVG diff (owid/owid-grapher-svgs@e1e16d3), almost all of these cases benefit from missing data being shown. Therefore, I will make it so that |
…citly set it to `hide`
e2ef106
to
609455c
Compare
…on-error data point
609455c
to
0d16ece
Compare
Okay, I now tried another attempt (see owid/owid-grapher-svgs@bb88642) where with I thought that makes sense, but now realize in the SVG diff that this doesn't really improve any of these charts. Will revert this change, then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Makes sense to me!
Slack discussion
Currently having it as
auto
(default) will hide missing data.I'll check with the SVG tester if that seems like a good default.
Before / After