Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too many files generated for CF pages #3818

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix too many files generated for CF pages #3818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/@ourworldindata/utils/src/image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { traverseEnrichedBlock } from "./Util.js"
import { OwidGdoc, OwidGdocType, ImageMetadata } from "@ourworldindata/types"
import { match, P } from "ts-pattern"

export const AUTHOR_BYLINE_WIDTH = 48
export const THUMBNAIL_WIDTH = 100
export const LARGE_THUMBNAIL_WIDTH = 350

Expand All @@ -15,7 +14,7 @@ export function getSizes(
): number[] {
if (!originalWidth) return []
// ensure a thumbnail and author byline is generated
const widths = [AUTHOR_BYLINE_WIDTH, THUMBNAIL_WIDTH]
const widths = [THUMBNAIL_WIDTH]
// start at large thumbnail and go up by 500 to a max of 1350 before we just show the original image
let width = LARGE_THUMBNAIL_WIDTH
while (width < originalWidth && width <= 1350) {
Expand Down
2 changes: 1 addition & 1 deletion site/gdocs/components/Image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const containerSizes: Record<ImageParentContainer, string> = {
["datapage"]: gridSpan6,
["full-width"]: "100vw",
["key-insight"]: gridSpan5,
["author-byline"]: "48px",
["author-byline"]: "100px",
["author-header"]: gridSpan2,
["span-5"]: gridSpan5,
["span-6"]: gridSpan6,
Expand Down