-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change DoDs to be spans instead of links #3815
Conversation
@@ -242,13 +242,4 @@ $zindex-controls-drawer: 150; | |||
.markdown-text-wrap__line:last-child { | |||
margin-bottom: 2px; | |||
} | |||
|
|||
a.dod-span { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need to override the styles for links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Marcel pointed out, we still need to add the styles to Grapher. Added a mixin for this.
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-07-26 08:04:43 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! For whatever reason, neither the styles nor the event handler applies in admin.
See this chart, for example, where "newborns" in the subtitle should be DoD-ified.
Ah, right: It's probably enough to make sure the DoD styles are explicitly included in admin. |
They don't link to anything and should not be rendered as links in HTML for cases like an Atom feed.
Did it with a mixin. Is that a sensible approach? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's great.
Co-authored-by: Marcel Gerber <[email protected]>
They don't link to anything and should not be rendered as links in HTML for cases like an Atom feed. See Slack discussion.