Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct population historical path #3814

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Jul 25, 2024

I recently changed the ETL path of the historical OMM.

This has affected the indicator-detection by regex. As a consequence, scatterplots using population historical are showing the complete population source, as reported by Pablo here.

Work on this was previously done in #3794 and discussed in slack

(Asked for two revisions, but just aiming at one revision (first one). Thanks!)

@owidbot
Copy link
Contributor

owidbot commented Jul 25, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fix-regex-omm-population

SVG tester:

Number of differences (default views): 111 (42a811) ❌
Number of differences (all views): 154 (0ea2c4) ❌

Edited: 2024-07-25 09:49:18 UTC
Execution time: 1.26 seconds

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

@lucasrodes lucasrodes merged commit dd252dd into master Jul 25, 2024
30 checks passed
@lucasrodes lucasrodes deleted the fix-regex-omm-population branch July 25, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants