Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author pages to sitemap #3811

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

larsyencken
Copy link
Contributor

@larsyencken larsyencken commented Jul 24, 2024

Fixes #3775

Include author pages in the sitemap.


For more details, open the Copilot Workspace session.

baker/sitemap.ts Outdated Show resolved Hide resolved
@owidbot
Copy link
Contributor

owidbot commented Jul 24, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-larsyencken-add-author-pages-to-sitemap

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-07-24 15:21:59 UTC
Execution time: 1.21 seconds

@marcelgerber
Copy link
Member

This works! See http://staging-site-larsyencken-add-author-pages-to-sitemap/sitemap.xml.

I notice that there are a few entries that have a lastmod of 1970-01-01. That's not really AI's fault but we should make sure we fix that either way.

It doesn't need as many other assets, and fixes the `lastmod` in the
sitemap so that it doesn't show the unix epoch time.
@larsyencken larsyencken force-pushed the larsyencken/add-author-pages-to-sitemap branch 2 times, most recently from 16ad023 to e3a7d31 Compare July 31, 2024 15:49
@larsyencken larsyencken force-pushed the larsyencken/add-author-pages-to-sitemap branch from e3a7d31 to 8a0522c Compare July 31, 2024 15:52
@larsyencken larsyencken requested a review from ikesau July 31, 2024 16:12
@larsyencken
Copy link
Contributor Author

@ikesau I added updatedAt to LinkedAuthors now and worked around another issue where updatedAt is accidentally set to the unix epoch. I'll file that separately.

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding updatedAt! Didn't realize it wasn't on there already 🙂

@larsyencken larsyencken merged commit 15b8fa5 into master Aug 2, 2024
23 checks passed
@larsyencken larsyencken deleted the larsyencken/add-author-pages-to-sitemap branch August 2, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author pages are not on the sitemap
4 participants