Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data insight feed and detail page #3801

Merged
merged 11 commits into from
Jul 29, 2024
Merged

New data insight feed and detail page #3801

merged 11 commits into from
Jul 29, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Jul 19, 2024

No description provided.

@owidbot
Copy link
Contributor

owidbot commented Jul 19, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-new-data-insight-detail

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-07-19 15:53:49 UTC
Execution time: 1.18 seconds

@rakyi rakyi force-pushed the new-data-insight-detail branch from af3352d to 683aa16 Compare July 22, 2024 09:30
@rakyi rakyi force-pushed the new-latest-data-insights branch from 6e4b5bf to 35d3ba8 Compare July 23, 2024 14:29
@rakyi rakyi force-pushed the new-data-insight-detail branch from 683aa16 to 3199fc3 Compare July 23, 2024 14:52
@rakyi rakyi requested a review from ikesau July 23, 2024 14:52
@rakyi rakyi marked this pull request as ready for review July 23, 2024 14:52
@rakyi rakyi force-pushed the new-data-insight-detail branch from 3199fc3 to 4cef801 Compare July 23, 2024 16:06
Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

QA'd CSS on all screens, published DIs on different days, copy button still works, etc 👍

@rakyi rakyi force-pushed the new-data-insight-detail branch from 4cef801 to 01f0a58 Compare July 24, 2024 14:13
Base automatically changed from new-latest-data-insights to master July 29, 2024 08:18
# Conflicts:
#	site/gdocs/components/LatestDataInsights.scss
#	site/gdocs/components/LatestDataInsights.tsx
#	site/gdocs/pages/DataInsight.scss
#	site/gdocs/pages/DataInsight.tsx
@rakyi rakyi merged commit 3ef43cf into master Jul 29, 2024
15 of 18 checks passed
@rakyi rakyi deleted the new-data-insight-detail branch July 29, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants