Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 add command for deleting Algolia index #3777

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

Marigold
Copy link
Contributor

@Marigold Marigold commented Jul 8, 2024

Command for deleting all Algolia indexes (implements #3563). Ops part https://github.com/owid/ops/pull/201.

@owidbot
Copy link
Contributor

owidbot commented Jul 8, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-delete-algolia-index

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-07-08 09:50:58 UTC
Execution time: 1.15 seconds

@Marigold Marigold force-pushed the delete-algolia-index branch from a0947f5 to a0bda5d Compare July 8, 2024 10:21
@Marigold Marigold requested a review from larsyencken July 8, 2024 10:50
Copy link
Contributor

@larsyencken larsyencken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a safety check to add.

baker/algolia/deleteAlgoliaIndex.tsx Show resolved Hide resolved
@Marigold Marigold force-pushed the delete-algolia-index branch from a0bda5d to c654740 Compare July 10, 2024 12:36
@Marigold Marigold requested a review from larsyencken July 10, 2024 12:36
@Marigold
Copy link
Contributor Author

@larsyencken culd you re-review, please? (There's also ops part here https://github.com/owid/ops/pull/201)

Copy link
Contributor

@larsyencken larsyencken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thing of beauty! :shipit:

@Marigold Marigold merged commit e16e534 into master Jul 10, 2024
12 of 14 checks passed
@Marigold Marigold deleted the delete-algolia-index branch July 10, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants