🐛 (key indicator) fix broken animation / TAS-535 #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
sophiamersmann
changed the title
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-07-01 08:34:40 UTC |
sophiamersmann
force-pushed
the
key-indicator-animation
branch
from
49f24c7 to
53561e6
Compare
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
ikesau
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3527 attempted to fix a bug where - after opening an accordion item using the keyboard - the focus unexpectedly jumped to the top of the page. This was fixed by programmatically focusing the content area after opening an accordion. Unfortunately, this breaks the scroll-into-view animation. To avoid interrupting the scroll-into-view animation, we wait a few hundred ms to focus the content area. But we don't really know how much time the animation needs, so the timeout time is set through experimentation. If you're extremely quick to continue navigating, you'll still jump to the top page and then back. This only happens in Safari though – I can't repro the original bug in Chrome or Firefox.
Not really happy with this fix, but can't think of another way...