Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the gdocs datepicker start on Monday #3753

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jun 28, 2024

No description provided.

@ikesau ikesau self-assigned this Jun 28, 2024
@owidbot
Copy link
Contributor

owidbot commented Jun 28, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-datepicker-startday

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-06-28 18:27:10 UTC
Execution time: 1.08 seconds

@ikesau ikesau force-pushed the datepicker-startday branch from 7a68c2a to a45a799 Compare June 28, 2024 18:30
@ikesau ikesau requested a review from rakyi July 1, 2024 05:06
Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, dayjs ships their own locale and apparently even for en_GB they have Sunday as the first day of the week. I guess we have no other way to fix this. Thanks!

@ikesau ikesau merged commit df78d6c into master Jul 9, 2024
15 checks passed
@ikesau ikesau deleted the datepicker-startday branch July 9, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants