Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ use UTC in the gdocs datepicker #3736

Merged
merged 2 commits into from
Jun 27, 2024
Merged

✨ use UTC in the gdocs datepicker #3736

merged 2 commits into from
Jun 27, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jun 21, 2024

I find the language of timezones difficult to write, but hopefully this very long comment explains what's going on here.

And if not, then this video can speak for itself 😁

utc.datepicker.mp4

@ikesau ikesau requested a review from rakyi June 21, 2024 20:34
@ikesau ikesau self-assigned this Jun 21, 2024
@owidbot
Copy link
Contributor

owidbot commented Jun 21, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-utc-datepicker

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-06-21 20:43:31 UTC
Execution time: 1.10 seconds

Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job getting it working! I'm not sure if it's worth the added complexity, but LGTM otherwise.

Don't forget to notify authors about the change.

@ikesau ikesau merged commit 22e4d63 into master Jun 27, 2024
20 checks passed
@ikesau ikesau deleted the utc-datepicker branch June 27, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants