feat: multi-dim data pages #3657
Conversation
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-07-25 17:23:31 UTC |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
marcelgerber
force-pushed
the
multi-dim-data-pages
branch
from
661ebdd to
f47861a
Compare
marcelgerber
force-pushed
the
multi-dim-data-pages
branch
3 times, most recently
from
6e96779 to
df0572f
Compare
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
marcelgerber
force-pushed
the
multi-dim-data-pages
branch
from
df0572f to
4fd99bb
Compare
marcelgerber
force-pushed
the
multi-dim-data-pages
branch
6 times, most recently
from
8b77661 to
f28470d
Compare
marcelgerber
force-pushed
the
multi-dim-data-pages
branch
3 times, most recently
from
b693073 to
c6cf2ca
Compare
marcelgerber
force-pushed
the
multi-dim-data-pages
branch
from
8008a4f to
9bef910
Compare
marcelgerber
force-pushed
the
multi-dim-data-pages
branch
from
ac5aaf4 to
dd97a07
Compare
There was a problem hiding this comment.
Very nice work! I had a few comments about moving some code and whether we should bake the default view into HTML.
I reviewed the react hooks code as far as I could but I am not familiar enough to be able to suggest improvements here - e.g. maybe there is an elegant way of implementing useMobxStateToReactState that does not mandate correctly wrapping the state getter in a useCallback, but I don't know about these things. Maybe it would be good if Ike could have a look over the hooks code specifically in this PR?
| }} | ||
| /> | ||
| <div id={OWID_DATAPAGE_CONTENT_ROOT_ID}> | ||
| {/* <DebugProvider debug={isPreviewing}> |
There was a problem hiding this comment.
Hm, wouldn't it be good to bake the default view into the HTML?
There was a problem hiding this comment.
I agree that we should definitely bake something, yes.
I'm not sure about what will make for the best UX - if a load of things are displayed and then are switched out one second after, that's not great. Will have to think about this.
There was a problem hiding this comment.
I've now added this to #3874.
|
-> This is now ready to be merged tomorrow; in this case with a squash merge! |
Implements #3795.
Review notes
You can fully ignore the stuff in
public/multi-dim. These are the 6 currently available MDD pages, with hardcoded slugs and configs. Go to/grapher/mdd-poverty,/grapher/mdd-causes-of-deathetc. to access them. This folder makes up most of the 6000 lines of code added.To enable baking locally, add
FEATURE_FLAGS = MultiDimDataPageto your.envfile.Most stuff is going on in
MultiDimDataPageContent,MultiDimDataPageBaker, andMultiDimDataPageSettingsPanel.And, feel free to reach out if anything is unclear!
TODOs