✨ (grapher) prevent controls from overflowing #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 1 (3c9272) ❌ Edited: 2024-06-10 12:14:38 UTC |
sophiamersmann
force-pushed
the
grapher-controls
branch
4 times, most recently
from
615d241 to
1478852
Compare
sophiamersmann
changed the title
sophiamersmann
force-pushed
the
grapher-controls
branch
from
1478852 to
3d95198
Compare
This was referenced Jun 3, 2024
sophiamersmann
force-pushed
the
grapher-controls
branch
from
3d95198 to
2cc9ee8
Compare
sophiamersmann
force-pushed
the
grapher-controls
branch
from
2cc9ee8 to
756ec13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps controls from overflowing on smaller screens. See screenshots 👇🏻
The "Show selection only" toggle on the table tab is moved into the settings drawer. The rest are just CSS touchups.
We compute the widths of the content switchers and the toggle to determine if there is enough space for the table toggle. I could have implemented this in a simpler way using breakpoints, but I wanted to make sure that we only hide the table toggle if absolutely necessary.