Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐝 (svg tester) prepare for move to foundation #3546

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Apr 28, 2024

Small tweaks to prepare the SVG tester for move to foundation. In particular,

  • the base URL is hard-coded to point to prod (this used to depend on the environment, i.e. was localhost for reference charts since they're usually exported locally and staging-site-x on staging, which then made every chart fail)
  • keep the SVG tester GitHub actions for now since it's convenient that they're setup to fail when differences were detected (the Buildkite jobs currently don't give any indication of success/failure) but remove the steps that commit/push to owid-grapher-svgs (in the future we want the Buildkite job to post a comment on a PR with a summary; if we have that, we can drop the GitHub actions)

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@sophiamersmann sophiamersmann force-pushed the svg-tester-foundation branch from d728211 to 76f4f0a Compare April 30, 2024 12:08
@sophiamersmann sophiamersmann merged commit dee7ba6 into master Apr 30, 2024
20 of 24 checks passed
@sophiamersmann sophiamersmann deleted the svg-tester-foundation branch April 30, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant