fix(baking): bake graphers in parallel, using multiple db transactions #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyx23
approved these changes
Apr 27, 2024
|
@marcelgerber amazing, please merge this asap 🙏 It's starting to be a serious drag on staging servers. It's not just performance, but sometimes it's just so slow that it runs into 30 min timeout. |
marcelgerber
force-pushed
the
baking-graphers-parallel
branch
from
8843ead to
3f16e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3462.
This doubles the baking speed of the
bakeAllChangedGrapherPagesVariablesPngSvgAndDeleteRemovedGraphersstep.There are probably also other baking steps that we want to use a similar pattern for - especially those using a read-only transaction (screw you, images!), and those that are currently using
pMaporPromise.all.