experiment: cloudflare images #3538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves all our images which are currently being served via either
/images/publishedor viaassets.ourworldindata.orgvia cloudflare workers, using an experimental worker set up atimages-test.owid.io- see https://github.com/owid/cloudflare-workers/pull/20 for that part.The caveats of CF Images apply: Cloudflare is not always happy to churn out pngs, and will often times produce jpegs instead, without us having much control over that. But otherwise, this all is pretty straightforward.
As an experiment, I also added some hacky code that also serves WP uploads via Cloudflare images.
We don't want to actually do this, because we already have resized variants available for all of these, and no new WP images are being uploaded.