Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 make key indicator collection more accessible #3527

Merged
merged 1 commit into from
May 30, 2024
Merged

🐛 make key indicator collection more accessible #3527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion site/gdocs/components/KeyIndicatorCollection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,12 @@ function AccordionItem({
const headerId = `${id}_header`
const contentId = `${id}_content`

// remove content from the tab sequence if it's not visible
useEffect(() => {
if (!contentRef.current) return
contentRef.current.inert = !isOpen
}, [isOpen, contentRef])

return (
<div
ref={ref}
Expand Down Expand Up @@ -182,6 +188,10 @@ function AccordionItem({
behavior: "smooth",
})
}

if (contentRef.current) {
contentRef.current.focus()
}
}, HEIGHT_ANIMATION_DURATION_IN_SECONDS * 1000)
}
}}
Expand All @@ -204,7 +214,13 @@ function AccordionItem({
role="region"
aria-labelledby={headerId}
>
<div ref={contentRef}>{children}</div>
<div
ref={contentRef}
tabIndex={isOpen ? 0 : -1}
aria-hidden={!isOpen}
>
{children}
</div>
</div>
</div>
)
Expand Down