🐛 correctly parse URLs in gdoc front matter #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
force-pushed
the
data-insight-grapher-url-links
branch
from
2776e0e to
489c854
Compare
marcelgerber
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
posts_gdocs.content->>"$.grapher-url"was being saved as<a href="https://ourworldindata.org/grapher/some-slug">https://ourworldindata.org/grapher/some-slug</a>due to Google's automatic linkifying.It's not rendered anywhere, and we were extracting it correctly for the
gdocs_posts_linkstable, hence us not catching it till now.So, this PR's of arguable utility, but it feels like it ought to be correct.