Improve docs/output, helpful for 3rd parties #3523
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Docker is persistent, as it should be, but, it can be problematic when one switches around projects which was what I did at my previous job. The instructions in the PR should conclusively "factory reset" docker so that OWID has no problem doing it's things.
When I first everything up it was more complicated and I feel this problem was because Docker for Desktop (D4D) doesn't report existing Docker images running via other tools. At my last place, which was a corporate company, we didn't pay the liscense for D4D and were given command line options that worked first time with little thought, whereas OWID clearly qualifies for free accounts.
new-session
throws aduplicate session
error if the TMux screen is closed without quitting, so an added line checks for the session and closes thegrapher
session beforenew-session
is run. This means the TMux session can be closed properly withCtrl+b, Q
or by closing the terminal window in some other way. If sessions are found, it will only kill off grapher, so if grapher doesn't exist, that is reported but doesn't stop the file.The MySQL infinite dot output might confuse people a bit. Looking at the message source and finding the
dev/null
destination suggests the result should be immediately be true but isn't for me for some reason. I'm looking at it while I'm here but not currently intending to change anything.Testing
I think all one has to do is stop all the TMux stuff then try and runNo, in fact runningmake
again. Without the steps to remove all containers I think the same thing will happen, whether those containers are OWID D4D ones or some thing left over on a 3rd party machine.make up
does work, and I think I may have improved it.For that
make up
change: to test, just remove that commit and see how it works without.I do have an old contracting laptop which is probably sitting with Dockers ready to pop up again, this would be a true test environment as it will be a closer analogue of my situation as a 3rd party contributor, pre-start. But it's one shot, so I've been incubating this problem while doing other things.
Condition of my local set-up
It works basically, as proven by the PRs I've submitted.