Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(util): cache /detect-country fetch #3513

Merged
merged 1 commit into from
Apr 18, 2024
Merged

enhance(util): cache /detect-country fetch #3513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/@ourworldindata/utils/src/Util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,14 +569,19 @@ export const fetchText = async (url: string): Promise<string> => {
})
}

export const getUserCountryInformation = async (): Promise<
const _getUserCountryInformation = async (): Promise<
UserCountryInformation | undefined
> =>
await fetch("/detect-country")
.then((res) => res.json())
.then((res) => res.country)
.catch(() => undefined)

// Memoized because this will pretty much never change during a session.
// The memoization, however, also means that any failures will also be cached.
// This is okay currently, because currently this information is very much an optional nice-to-have.
export const getUserCountryInformation = memoize(_getUserCountryInformation)

export const stripHTML = (html: string): string => striptags(html)

// Math.rand doesn't have between nor seed. Lodash's Random doesn't take a seed, making it bad for testing.
Expand Down