Grapher baking performance enhancements #3482
Conversation
marcelgerber
force-pushed
the
baking-perf-enhancements
branch
from
71101e6 to
f9f3bdd
Compare
|
Continued to work on this for a bit, think this is ready for review now. Observed performance of |
| export class AddPostsSlugIndex1712842552502 implements MigrationInterface { | ||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(`-- sql | ||
| ALTER TABLE posts ADD INDEX idx_posts_slug (slug(100)); |
There was a problem hiding this comment.
I think we should bump this to 130 maybe? The longest slug in my snapshot is 122 chars long. As far as I understand indices in mysql this would still work but why not make it a bit bigger and then all values will fit.
There was a problem hiding this comment.
Hm, I honestly don't think it's necessary (unless we would want this index to be unique).
Otherwise, there are quite certainly not gonna be two slugs whose prefixes of length 100 are the same length, and then it's just the same.
Various attempts to improve #3462