Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated "how to use" links #3477

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix outdated "how to use" links #3477

merged 1 commit into from
Apr 11, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Apr 10, 2024

These are the only places I found that referenced that old page(s?).

Fixes #2013.

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One small change if you agree; otherwise this is good to go :shipit:

data-track-note="footer_navigation"
>
How to use
FAQs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's nicer to write this out as Frequently asked questions

Copy link
Contributor Author

@rakyi rakyi Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is FAQs on the about page, so I opted for consistency and also there isn't much space in the footer column, so the longer link wraps on a medium screen (others don't). Do you feel strongly that we shouldn't use the acronym?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, makes sense. Good to go ahead then :)

@rakyi rakyi merged commit 6be7d58 into master Apr 11, 2024
29 checks passed
@rakyi rakyi deleted the fix-how-to-use-links branch April 11, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static links to page how-to-use-our-world-in-data, which is a redirect
2 participants