Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yarn to 4.1.1 and remove Volta config #3469

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Bump yarn to 4.1.1 and remove Volta config #3469

merged 4 commits into from
Apr 10, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Apr 10, 2024

I noticed we had two different versions of Yarn in deps, so I made it the same and also updated it to the latest given I was touching it anyway.

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! We're currently still using a yarnPath-based Yarn installation.

Yarn nowadays recommends to use Corepack, which ships with recent versions of Node, but is disabled by default (can be enabled using corepack enable). We should probably switch over to Corepack at some point in the near future (and thereby tell the team to enable it), but for now let's stay with yarnPath.

For that to work correctly, you'll need to also run yarn set version latest in order to update the Yarn release that's then included with the repo. Thank you!

@rakyi
Copy link
Contributor Author

rakyi commented Apr 10, 2024

Thanks, I ran the command to update Yarn properly.

By running `yarn set version latest`.
rakyi and others added 2 commits April 10, 2024 08:50
It is redundant with other node version managers like fnm and yarnPath.
@rakyi
Copy link
Contributor Author

rakyi commented Apr 10, 2024

After thinking about this more, we don't really need Volta when we are using the yarnPath and we also have .nvmrc that tools like nvm and fnm use, so I decided to remove the Volta config. I'll keep the PR open for a bit in case someone from the team will object to the removal in Slack.

@rakyi rakyi changed the title Bump yarn to 4.1.1 Bump yarn to 4.1.1 and remove Volta config Apr 10, 2024
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@rakyi rakyi merged commit 154574f into master Apr 10, 2024
22 checks passed
@rakyi rakyi deleted the update-yarn branch April 10, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants