-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump yarn to 4.1.1 and remove Volta config #3469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! We're currently still using a yarnPath
-based Yarn installation.
Yarn nowadays recommends to use Corepack, which ships with recent versions of Node, but is disabled by default (can be enabled using corepack enable
). We should probably switch over to Corepack at some point in the near future (and thereby tell the team to enable it), but for now let's stay with yarnPath
.
For that to work correctly, you'll need to also run yarn set version latest
in order to update the Yarn release that's then included with the repo. Thank you!
Thanks, I ran the command to update Yarn properly. |
By running `yarn set version latest`.
It is redundant with other node version managers like fnm and yarnPath.
After thinking about this more, we don't really need Volta when we are using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
I noticed we had two different versions of Yarn in deps, so I made it the same and also updated it to the latest given I was touching it anyway.