-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove remaining TypeORM call #3463
Conversation
WalkthroughWalkthroughIn this update, we've refined our backend's interaction with the database, specifically focusing on how we reference and manipulate data related to posts. The key adjustments include a more standardized naming convention for table references—shifting from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
@@ -2162,7 +2160,7 @@ postRouteWithRWTransaction( | |||
// which means that we can't wrap this in a transaction. We should probably | |||
// move posts to use typeorm as well or at least have a typeorm alternative for it | |||
await trx | |||
.table(postsTable) | |||
.table(PostsTableName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider extracting complex logic into separate functions or modules.
The logic for creating or updating Google Docs based on posts appears complex and is embedded within a large function. Extracting this logic into separate, well-named functions or even a dedicated module could improve readability, maintainability, and testability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that this got through!
This is the last remaining call to TypeORM's
dataSource.getRepository
, which is failing.