🐛 (marimekko) drop entities without data

[sophiamersmann]

• Fixes a bug where Marimekko charts offered entities for selection that are not included in the chart
• Example: this chart offers "West Germany" for selection but we don't have any data for West Germany for any of the years
• Solution:
  • Marimekko charts should use the transformed table for the entity selector (they're similar to scatter plots and slope charts in that regard, as all entities are on screen for a selected year)
  • There was a small bug in the transformTable function: We also don't show a "No data" area if we don't have a x-dimension

SVG tester

• After making this change, it becomes apparent that tolerance is applied twice, and some entities are displayed for years when they shouldn't be
• For example: United Arab Emirates show up on staging but not on live
  • United Arab Emirates has data for a single year (2013), and the indicator's tolerance is set to 5
  • In production, United Arab Emirates shows up for the years 2008-2018 (correct), but on staging shows up for 2003-2022 (10 years to both sides instead of 5)
  • I think this happens because tolerance is applied in the transformTable function and then again when filtering for the currently displayed year (see next PR)

[sophiamersmann]

• 🐛 (marimmeko) do not apply tolerance twice #3491
• 🐛 (marimekko) drop entities without data #3455 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite