-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (grapher) pull in data types from metadata #3375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelgerber
approved these changes
Mar 20, 2024
sophiamersmann
force-pushed
the
ordinal-types
branch
from
March 28, 2024 10:09
20a8611
to
b191d4e
Compare
sophiamersmann
force-pushed
the
data-types
branch
from
March 28, 2024 10:12
b10cb93
to
f8bf532
Compare
sophiamersmann
force-pushed
the
data-types
branch
from
March 28, 2024 11:14
f8bf532
to
1e208a7
Compare
In theory, we could check if the |
marcelgerber
requested changes
Apr 2, 2024
Co-authored-by: Marcel Gerber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Wait for #3362 to be merged into master.
Open question: Should we splitUsingNumeric
intoInteger
andFloat
?Integer
forint
andNumeric
forfloat
Closes #1692