🐝 (dod) remove automatic checking #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
sophiamersmann
force-pushed
the
dod-in-axis-labels
branch
from
5d197fc to
bbc1f17
Compare
sophiamersmann
force-pushed
the
dod-remove-automatic-checking
branch
from
ae877fc to
6bef8c7
Compare
sophiamersmann
force-pushed
the
dod-in-axis-labels
branch
from
bbc1f17 to
aed3cfb
Compare
sophiamersmann
force-pushed
the
dod-remove-automatic-checking
branch
from
6bef8c7 to
0ebd8bd
Compare
Merge activity
|
sophiamersmann
force-pushed
the
dod-remove-automatic-checking
branch
from
0ebd8bd to
060d2f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the parent PR, I added a strategy to check for DoDs with a given prefix automatically for indicator names that are used as axis labels. For example, if the display name of an indicator is "Life expectancy", we would automatically check for a DoD with the name
grapher_indicator_life-expectancy(it's explained in more detail in the PR description). We decided not to do this now, but we might want to do this in the future. This PR removes the feature. If we do want to enable it in the future, we can do so by reverting this PR.