Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(static-chart): don't render chart on table tab #3285

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix(static-chart): don't render chart on table tab #3285

merged 1 commit into from
Mar 4, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Mar 4, 2024 •
edited
Loading

Fixes #3283 at the source, and aligns StaticCaptionedChart and CaptionedChart a bit here.

sophiamersmann
sophiamersmann approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this at the source 👌🏻

@marcelgerber marcelgerber merged commit c4f78ea into master Mar 4, 2024
24 of 26 checks passed
@marcelgerber marcelgerber deleted the fix-static-table-issue branch March 4, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiamersmann sophiamersmann sophiamersmann approved these changes

Assignees

@marcelgerber marcelgerber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Baking fails with TypeError: Cannot read properties of undefined (reading 'toFixed')
2 participants
@marcelgerber @sophiamersmann