🐛 (grapher) guard against undefined

[sophiamersmann]

Baking fails for chart sources-population-dataset with the following error message:

TypeError: Cannot read properties of undefined (reading 'toFixed')
_HorizontalAxis.place (/home/owid/owid-grapher/packages/@ourworldindata/grapher/src/axis/Axis.ts:387:46)
<anonymous> (/home/owid/owid-grapher/packages/@ourworldindata/grapher/src/barCharts/DiscreteBarChart.tsx:471:33)
Array.map (<anonymous>)
DiscreteBarChart.render (/home/owid/owid-grapher/packages/@ourworldindata/grapher/src/barCharts/DiscreteBarChart.tsx:462:25)
Object.allowStateChanges [as _allowStateChanges] (/home/owid/owid-grapher/node_modules/mobx/lib/mobx.js:991:15)
/home/owid/owid-grapher/node_modules/mobx-react/index.js:851:28
trackDerivedFunction (/home/owid/owid-grapher/node_modules/mobx/lib/mobx.js:776:24)
Reaction.track (/home/owid/owid-grapher/node_modules/mobx/lib/mobx.js:1806:22)
DiscreteBarChart.reactiveRender [as render] (/home/owid/owid-grapher/node_modules/mobx-react/index.js:845:16)
DiscreteBarChart.makeComponentReactive (/home/owid/owid-grapher/node_modules/mobx-react/index.js:915:27)

Guarding against undefined when placing the value on the axis "fixes" this, but it's not clear to me why DiscreteBar chart is even rendered for the chart in question. https://ourworldindata.org/grapher/sources-population-dataset doesn't have a chart tab and is, in theory, a line chart

[sophiamersmann]

• 🐛 (grapher) guard against undefined #3284 👈
• 🐝 (grapher) refactor horizontal axis views #3274
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

[sophiamersmann]

Merge activity

• Mar 4, 8:34 AM EST: @sophiamersmann started a stack merge that includes this pull request via Graphite.
• Mar 4, 8:35 AM EST: Graphite rebased this pull request as part of a merge.
• Mar 4, 8:36 AM EST: @sophiamersmann merged this pull request with Graphite.