-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 (slope) replace custom y-axis with shared component #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite |
sophiamersmann
force-pushed
the
slope-hover-interaction
branch
from
March 5, 2024 11:25
79f7bf7
to
1b74736
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 5, 2024 11:25
594b010
to
7753b56
Compare
sophiamersmann
force-pushed
the
slope-hover-interaction
branch
from
March 5, 2024 13:28
1b74736
to
0c94b50
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 5, 2024 13:28
7753b56
to
505e34f
Compare
sophiamersmann
force-pushed
the
slope-hover-interaction
branch
from
March 6, 2024 14:25
0c94b50
to
ff9abda
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 6, 2024 14:25
505e34f
to
97afcfb
Compare
sophiamersmann
force-pushed
the
slope-hover-interaction
branch
from
March 7, 2024 08:56
ff9abda
to
e14309a
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 7, 2024 08:56
97afcfb
to
f0db84f
Compare
sophiamersmann
force-pushed
the
slope-hover-interaction
branch
from
March 7, 2024 09:15
e14309a
to
1dcd907
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 7, 2024 09:15
f0db84f
to
a4b8dcf
Compare
sophiamersmann
force-pushed
the
slope-hover-interaction
branch
from
March 7, 2024 09:56
1dcd907
to
8d58cce
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 7, 2024 09:56
a4b8dcf
to
27f0199
Compare
marcelgerber
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Feel free to address these two nits or not, otherwise this is pretty great.
packages/@ourworldindata/grapher/src/slopeCharts/SlopeChart.tsx
Outdated
Show resolved
Hide resolved
packages/@ourworldindata/grapher/src/slopeCharts/SlopeChart.tsx
Outdated
Show resolved
Hide resolved
sophiamersmann
force-pushed
the
slope-hover-interaction
branch
from
March 7, 2024 17:02
8d58cce
to
225a57d
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 7, 2024 17:02
27f0199
to
1a89de2
Compare
sophiamersmann
force-pushed
the
slope-hover-interaction
branch
from
March 8, 2024 13:52
5242128
to
9cc854d
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 8, 2024 13:52
1a89de2
to
254f1c6
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
2 times, most recently
from
March 14, 2024 08:38
15735ac
to
d59c78e
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 21, 2024 13:51
d59c78e
to
2b051a7
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 21, 2024 13:52
2b051a7
to
584bf50
Compare
sophiamersmann
force-pushed
the
slope-y-axis
branch
from
March 21, 2024 15:17
584bf50
to
03c1d5e
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the SlopeChart's custom y-axis component with the
<VerticalAxisComponent />
that is a shared component used by a number of chart types.Summary
Context
Part of a larger body of work. See stack 👇🏻