Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 (slope) replace custom y-axis with shared component #3273

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Mar 1, 2024

Replaces the SlopeChart's custom y-axis component with the <VerticalAxisComponent /> that is a shared component used by a number of chart types.

Summary

  • In theory, this should be a pure refactor without any visual changes
  • But we want to remove the axis labels on the right anyway, so there is no need to re-construct them in this PR
  • I also added some tick marks to make it obvious that the labels on the left amount to an axis, and I added gridlines to visually connect the axis to the actual chart area
  • Christian hasn't done a design review yet, so details might change, but the bulk of the work (replacing the axis component) is ready to review

Context

Part of a larger body of work. See stack 👇🏻

@sophiamersmann sophiamersmann force-pushed the slope-hover-interaction branch from 79f7bf7 to 1b74736 Compare March 5, 2024 11:25
@sophiamersmann sophiamersmann force-pushed the slope-hover-interaction branch from 1b74736 to 0c94b50 Compare March 5, 2024 13:28
@sophiamersmann sophiamersmann force-pushed the slope-hover-interaction branch from 0c94b50 to ff9abda Compare March 6, 2024 14:25
@sophiamersmann sophiamersmann force-pushed the slope-hover-interaction branch from ff9abda to e14309a Compare March 7, 2024 08:56
@sophiamersmann sophiamersmann force-pushed the slope-hover-interaction branch from e14309a to 1dcd907 Compare March 7, 2024 09:15
@sophiamersmann sophiamersmann force-pushed the slope-hover-interaction branch from 1dcd907 to 8d58cce Compare March 7, 2024 09:56
@sophiamersmann sophiamersmann marked this pull request as ready for review March 7, 2024 10:08
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Feel free to address these two nits or not, otherwise this is pretty great.

@sophiamersmann sophiamersmann force-pushed the slope-hover-interaction branch from 8d58cce to 225a57d Compare March 7, 2024 17:02
@sophiamersmann sophiamersmann force-pushed the slope-hover-interaction branch from 5242128 to 9cc854d Compare March 8, 2024 13:52
Base automatically changed from slope-hover-interaction to master March 11, 2024 12:46
@sophiamersmann sophiamersmann force-pushed the slope-y-axis branch 2 times, most recently from 15735ac to d59c78e Compare March 14, 2024 08:38
Copy link
Member Author

sophiamersmann commented Mar 22, 2024

Merge activity

@sophiamersmann sophiamersmann merged commit 77ae76d into master Mar 22, 2024
24 of 30 checks passed
@sophiamersmann sophiamersmann deleted the slope-y-axis branch March 22, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants