Data insights in sitemap and site nav #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlbrgl
approved these changes
Mar 1, 2024
| @@ -698,7 +701,10 @@ export class SiteBaker { | |||
|
|
|||
| private async bakeDataInsights() { | |||
There was a problem hiding this comment.
you could pass knex here from the parent caller (it's already available there)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds data insights to the sitemap and nav, and half-heartedly updates some data insight DB code to use Knex, before stopping arbitrarily to avoid spilling out into having to refactor the entire Gdocs codebase.
Local sitemap with
DATA_INSIGHTS_INDEX_PAGE_SIZEtemporarily set to2:The site nav Resources menu:
