Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 add reusable Button component #3254

Merged
merged 4 commits into from
Mar 1, 2024
Merged

🎉 add reusable Button component #3254

merged 4 commits into from
Mar 1, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Feb 27, 2024

Makes a new component for the ~~Button~~ that we're using everywhere

Contemplated hiding the icon when onClick is defined but decided to cross that bridge when we come to it.

Mobile

red-button-mobile
master-mobile

Desktop

master-desktop
red-button-desktop

@ikesau ikesau self-assigned this Feb 27, 2024
Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice effort 👍🏻

@ikesau ikesau merged commit 6c5ea96 into master Mar 1, 2024
14 of 15 checks passed
@ikesau ikesau deleted the red-button branch March 1, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants