Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (svg tester) fix all-views action for the master branch #3251

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Feb 27, 2024

  • The all-views SVG tester pushes its changes to a branch named <my-branch>__all-views
  • If run from the master branch, we want to push to the owid-grapher-svgs repo's master branch, but the action pushes to master__all-views. It also fails with differences on master, because we have some branch-name = 'master' checks (which don't work if the current branch name is master__all-views)
  • This is fixed by using the master branch if on master, i.e.:
    • If on master, keep the branch name master
    • If not on master, use <my-branch>__all-views

Note that the SVG tester fails because one of my recent merges into master was supposed to update the owid-grapher-svgs repo but didn't (because the action failed early)

Copy link
Member Author

sophiamersmann commented Feb 27, 2024

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - sorry for not catching that in the original PR!

@sophiamersmann sophiamersmann merged commit 3cfae90 into master Feb 27, 2024
23 of 25 checks passed
@sophiamersmann sophiamersmann deleted the fix-svg-tester-for-master-branch branch February 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants