Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 bake gdoc images as PNG instead of WebP #3248

Merged
merged 3 commits into from
Feb 27, 2024
Merged

🔨 bake gdoc images as PNG instead of WebP #3248

merged 3 commits into from
Feb 27, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Feb 26, 2024 •
edited
Loading

Lossless WebP images are typically 26% smaller than the same images in PNG format.

- MDN

Unfortunately, WebP is not as well-supported as PNG in most operating systems and programs, which Max and Este feel is more important when it comes to people using our graphics in their documents. 😢

Resolves #3238
Resolves #3220

@ikesau ikesau requested a review from danyx23 February 26, 2024 21:52
danyx23
danyx23 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - in Image.tsx:107 there is a reference to image/webp in an if branch that checks if we are previewing. Is that fine or should that change as well?

@ikesau ikesau merged commit 48e6946 into master Feb 27, 2024
14 of 17 checks passed
@ikesau ikesau deleted the png-instead-of-webp branch February 27, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyx23 danyx23 danyx23 approved these changes

Assignees

@ikesau ikesau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch baked images to PNG instead of webp Featured image og:image doesn't work with non-PNG images
2 participants
@ikesau @danyx23