🔨 remove old Frontpage code #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlbrgl
requested changes
Feb 28, 2024
baker/siteRenderers.tsx
Outdated
Comment on lines
257
to
263
| const gdocHomepageResult = await knex.raw<{ id: string }>( | ||
| `--sql | ||
| SELECT id | ||
| FROM posts_gdocs | ||
| WHERE content->>"$.type" = "${OwidGdocType.Homepage}" | ||
| AND published = TRUE` | ||
| ) |
There was a problem hiding this comment.
We probably need to revert this change:
- the "--" needs a space after it (otherwise I get a syntax error)
- gdocHomepageResult is an array so gdocHomepageResult.id below doesn't return what we would expect
There was a problem hiding this comment.
Wow yeah this was completely broken. Rewrote it and put the query in db.ts
|
The removal looks ok and makes sense, but I'm not too sure about the new Homepage.scss. I'm assuming it would mostly disappear on rebase? |
ikesau
force-pushed
the
remove-old-frontpage-code
branch
from
d52422a to
30aa001
Compare
|
@mlbrgl To be clear, I renamed Everything in it is now used. There's just some rules from the old page that are still used (the newsletter stuff) which follows a slightly different naming convention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grepped each of the classes in
homepage.scssand removed them if they were only used inFrontpage.tsxAlso removes the old
frontPageConfigstuff.