Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (discrete bar) fix broken layout #3244

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Feb 26, 2024

Summary

  • I noticed that one of our DiscreteBar charts didn't draw bars correctly (see screenshot below, top row, second chart)
  • There was a small issue in how we calculated the available space. Too much space was subtracted on the left

Screenshots

Before After
Screenshot 2024-02-26 at 14 51 17 Screenshot 2024-02-26 at 14 51 32

Copy link
Member Author

sophiamersmann commented Feb 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@sophiamersmann sophiamersmann force-pushed the fix-discrete-bar-broken-layout branch from 7f52d6c to 5693a5b Compare February 26, 2024 14:47
@sophiamersmann sophiamersmann merged commit 798b63a into master Feb 27, 2024
14 of 18 checks passed
@sophiamersmann sophiamersmann deleted the fix-discrete-bar-broken-layout branch February 27, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant