New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (key-indicator) make sure title matches the datapage title #3230

Merged

ikesau merged 1 commit into master from fix-key-indicator-title-in-collection

Feb 22, 2024

Member

sophiamersmann commented Feb 22, 2024

In the key indicator block, the key indicator title (pulled from the metadata) didn't always match the datapage title
The datapage title uses a chain of metadata properties to resolve the correct title
- The key indicator block should use the same chain, but I forgot to include the chart config title

Example:

Screenshot 2024-02-22 at 14 37 43


          🐛 (key-indicator) match datapage title

6fb716b

sophiamersmann requested a review from ikesau

February 22, 2024 13:50

github-actions bot assigned sophiamersmann

ikesau approved these changes

View reviewed changes

ikesau merged commit edc93b1 into master

24 checks passed

ikesau deleted the fix-key-indicator-title-in-collection branch

February 22, 2024 19:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet