Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (admin) persist entities for stacked charts more often #3205

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

sophiamersmann
Copy link
Member

  • When creating a new chart, we want to sample a random set of entities
  • But when editing a chart, we usually want to persist entities (unless it doesn't make sense)
  • For stacked charts (StackedBar, StackedArea, StackedDiscreteBar), we were throwing away entities more often than necessary
  • This PR implements two improvements:
    • Stacked charts persist a single entity and only sample new entities when the current selection is empty
    • StackedDiscreteBar charts are treated like other stacked charts – see above

@sophiamersmann sophiamersmann merged commit 88dcf4e into master Feb 19, 2024
26 of 27 checks passed
@sophiamersmann sophiamersmann deleted the admin-persist-entities branch February 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant