Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 use absolute URL instead of relative for allExplorers.json fetch #3181

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Feb 8, 2024

I'm not sure why this suddenly broke, but I think this will fix it?

Might hold off on merging until we can work out what changed.

Summary by CodeRabbit

  • Refactor
    • Updated the fetch URL for retrieving all explorers to enhance administrative access.

@ikesau ikesau requested a review from mlbrgl February 8, 2024 17:19
@ikesau ikesau self-assigned this Feb 8, 2024
Copy link

coderabbitai bot commented Feb 8, 2024

Walkthrough

This update primarily focuses on enhancing the administrative capabilities of the software by refining the process used to fetch a list of explorers. Specifically, it adjusts the API endpoint accessed by the fetchAllExplorers method, ensuring it targets the correct administrative path. This minor yet crucial adjustment streamlines the functionality within the administrative panel, improving data retrieval efficiency for administrators.

Changes

File Path Change Summary
.../ExplorersListPage.tsx Updated the fetch URL in fetchAllExplorers by adding /admin/ to the beginning of GetAllExplorersRoute.

🐇✨
In the realm of code, where explorers roam,
A path was tweaked, in their digital home.
/admin/ prepended, with a swift, keen hop,
Ensuring the journey, without a flop.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a9497ba and 3f16191.
Files selected for processing (1)
  • explorerAdminClient/ExplorersListPage.tsx (1 hunks)

@@ -283,7 +283,7 @@ export class ExplorersIndexPage extends React.Component<{
private async fetchAllExplorers() {
const { searchInput } = this

const response = await fetch(GetAllExplorersRoute)
const response = await fetch(`/admin/${GetAllExplorersRoute}`)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to prepend /admin/ directly in the fetch call makes the URL absolute relative to the domain root. Consider using BAKED_BASE_URL to ensure the URL is correctly resolved in different environments.

- const response = await fetch(`/admin/${GetAllExplorersRoute}`)
+ const response = await fetch(`${BAKED_BASE_URL}/admin/${GetAllExplorersRoute}`)

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
const response = await fetch(`/admin/${GetAllExplorersRoute}`)
const response = await fetch(`${BAKED_BASE_URL}/admin/${GetAllExplorersRoute}`)

@mlbrgl
Copy link
Member

mlbrgl commented Feb 8, 2024

I can't test right now, but that should do it. I'd say merge it, and then we can figure out what went wrong. Having the explorer admin broken is a great motivator 😅 but is not great.

@ikesau ikesau merged commit 8838c5c into master Feb 8, 2024
24 checks passed
@ikesau ikesau deleted the explorer-admin-route branch February 8, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants