-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 use absolute URL instead of relative for allExplorers.json fetch #3181
Conversation
WalkthroughThis update primarily focuses on enhancing the administrative capabilities of the software by refining the process used to fetch a list of explorers. Specifically, it adjusts the API endpoint accessed by the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -283,7 +283,7 @@ export class ExplorersIndexPage extends React.Component<{ | |||
private async fetchAllExplorers() { | |||
const { searchInput } = this | |||
|
|||
const response = await fetch(GetAllExplorersRoute) | |||
const response = await fetch(`/admin/${GetAllExplorersRoute}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change to prepend /admin/
directly in the fetch call makes the URL absolute relative to the domain root. Consider using BAKED_BASE_URL
to ensure the URL is correctly resolved in different environments.
- const response = await fetch(`/admin/${GetAllExplorersRoute}`)
+ const response = await fetch(`${BAKED_BASE_URL}/admin/${GetAllExplorersRoute}`)
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
const response = await fetch(`/admin/${GetAllExplorersRoute}`) | |
const response = await fetch(`${BAKED_BASE_URL}/admin/${GetAllExplorersRoute}`) |
I can't test right now, but that should do it. I'd say merge it, and then we can figure out what went wrong. Having the explorer admin broken is a great motivator 😅 but is not great. |
I'm not sure why this suddenly broke, but I think this will fix it?
Might hold off on merging until we can work out what changed.
Summary by CodeRabbit