💄 (grapher) don't use viewport height for grapher on mobile

[sophiamersmann]

• Reverts Grapher redesign: Resize chart height based on the viewport in gdoc articles (on mobile) #2605
• Grapher redesign: Resize chart height based on the viewport in gdoc articles (on mobile) #2605 was an attempt to give Grapher a bit more vertical space if possible
• but in the case of maps, it only adds whitespace
• and in the case of charts, it does give more space to that chart but also yields a suboptimal aspect ratio
• in the case of tables, the extra space is valuable, but I value maps & charts higher
• all in all, I think Grapher redesign: Resize chart height based on the viewport in gdoc articles (on mobile) #2605 was net negative, so I'm reverting it

Summary by CodeRabbit

• Style
  • Standardized and simplified the height properties for charts and figures across the site.
  • Removed responsive styling specific to small screens for a more consistent viewing experience.

[coderabbitai]

Warning

Rate Limit Exceeded

@sophiamersmann has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 34 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 96c16fd and 9e3c469.

Walkthrough

The changes focus on simplifying and refining CSS styling across several components, particularly for charts and figures. By introducing a new variable for slide content height, removing responsive and conditional stylings for small screens, and eliminating complex height calculations, the updates aim to streamline the presentation and responsiveness of graphical elements on the website.

Changes

Files	Change Summary
site/blocks/KeyInsights.scss	Introduced $slide-content-height variable; updated height property usage.
site/gdocs/components/.../AllCharts.scss	Removed responsive styling for figure[data-grapher-src].
site/gdocs/components/Chart.scss	Simplified height definition by removing small screen conditional styling.
site/gdocs/components/.../centered-article.scss	Removed complex height calculation for small screens.

Related issues

• Tracking issue: Mobile Grapher #3070: The simplification of CSS, especially around charts, might indirectly improve mobile user experience by making the layout more predictable and possibly addressing the tooltip overflow issue by reducing complexity.

🐇✨
In the land of code and sprite,
A rabbit hopped with sheer delight.
"Look at these changes, sleek and bright,
For graphs to shine, both day and night!"
🌟📊

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 96c16fd and fc13267.

Files selected for processing (4)

• site/blocks/KeyInsights.scss (3 hunks)
• site/gdocs/components/AllCharts.scss (1 hunks)
• site/gdocs/components/Chart.scss (1 hunks)
• site/gdocs/components/centered-article.scss (1 hunks)

Files skipped from review due to trivial changes (3)

• site/gdocs/components/AllCharts.scss
• site/gdocs/components/Chart.scss
• site/gdocs/components/centered-article.scss

Additional comments: 3

site/blocks/KeyInsights.scss (3)

• 1-1: Introduced $slide-content-height variable and assigned it to $grapher-height. Ensure $grapher-height is defined and imported correctly to avoid reference errors.
• 100-100: Replaced conditional variable with $slide-content-height. Verify that this change does not affect the responsiveness and intended behavior on different screen sizes.
• 114-114: Usage of $slide-content-height for setting height. Confirm consistency and correctness in the context of larger layout adjustments, especially for larger screens.