🐛 (discrete-bar) fix charts with projected data #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
sophiamersmann
force-pushed
the
fix-broken-bar-chart-with-projected-data
branch
from
ebef6f8 to
f446517
Compare
sophiamersmann
force-pushed
the
fix-broken-bar-chart-with-projected-data
branch
from
f446517 to
c24cb9d
Compare
|
This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected. |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes DiscreteBar: Single-year line charts are broken for projected data #3069
there are two ways of fixing this:
columninstead ofentitysuch that – for a single country – both y-variables are plotted (they don't show up at the same time because they have no time overlap)entity). that way, we would get two distinct bar charts – one for each y-column, i.e. one for historical and one for future data – where both bar charts display a single entityThe first solution produces the better result I think.
Example: live / staging