🔨 add wrangler to package.json #3059
Conversation
ops/buildkite/deploy-content
Outdated
| @@ -119,7 +119,7 @@ deploy_to_cloudflare() { | |||
| # for branch-specific non-production deploys, use `--branch master` | |||
| cd dist | |||
| # trim \r, they remove previous logs in buildkite | |||
| env $(grep "^CLOUDFLARE" ../owid-grapher/.env | xargs -0) npx wrangler pages deploy . --project-name "$PROJECT_NAME" 2>&1 | tr -d '\r' | |||
| env $(grep "^CLOUDFLARE" ../owid-grapher/.env | xargs -0) yarn wrangler pages deploy . --project-name "$PROJECT_NAME" 2>&1 | tr -d '\r' | |||
There was a problem hiding this comment.
@Marigold did you manage to make this work? It should work in https://github.com/owid/ops/pull/122 since it is running from a full owid-grapher folder but it is here running from dist which doesn't have a package.json
There was a problem hiding this comment.
Sorry, I was in a hurry yesterday, messed up testing, requested your review and then made a draft out of it 🤦
I've changed it to node_modules/wrangler/bin/wrangler.js and left a comment about node_modules/.bin/wrangler. It should work now. Still figuring out why is it breaking.
There was a problem hiding this comment.
no worries! I was commenting in case it's useful (also for me 🙂). I haven't run it in this context but the same command in deploy-content-preview works as expected, so ✅.
Running
npx wranglerinstalls wrangler globally in the cache and could have unintended consequences (changing versions, etc.). Install it as dev dependency.Related PR in ops https://github.com/owid/ops/pull/122
This should help with #3055 (review)