Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 GdocPost.tags is supposed to always exist but doesn't when accessing the featured content gdoc #3048

Merged
merged 1 commit into from
Dec 28, 2023
Merged

🐛 GdocPost.tags is supposed to always exist but doesn't when accessing the featured content gdoc #3048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions db/model/Gdoc/GdocPost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class GdocPost extends GdocBase implements OwidGdocPostInterface {
_validateSubclass = async (): Promise<OwidGdocErrorMessage[]> => {
const errors: OwidGdocErrorMessage[] = []

if (!this.tags.length) {
if (!this.tags?.length) {
if (this.content.type !== OwidGdocType.Fragment) {
errors.push({
property: "content",
Expand Down Expand Up @@ -151,7 +151,7 @@ export class GdocPost extends GdocBase implements OwidGdocPostInterface {
}

async loadRelatedCharts(): Promise<void> {
if (!this.tags.length || !this.hasAllChartsBlock) return
if (!this.tags?.length || !this.hasAllChartsBlock) return

const connection = await getConnection()
const relatedCharts = await connection.query(
Expand Down
Loading